From: Filippo Valsorda Date: Thu, 7 Jun 2018 20:24:52 +0000 (-0400) Subject: crypto/tls: expand docs on client-side session ticket support X-Git-Tag: go1.11beta1~182 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=9417ff55c35e0a1623af2a05c6e714c660ad6b4f;p=gostls13.git crypto/tls: expand docs on client-side session ticket support Users are sometimes confused why session tickets are not enabled even if SessionTicketsDisabled is false. Change-Id: I3b783d2cf3eed693a3ad6acb40a8003db7e0b648 Reviewed-on: https://go-review.googlesource.com/117255 Reviewed-by: Adam Langley --- diff --git a/src/crypto/tls/common.go b/src/crypto/tls/common.go index 76b1f6e5c4..423787b415 100644 --- a/src/crypto/tls/common.go +++ b/src/crypto/tls/common.go @@ -459,7 +459,8 @@ type Config struct { PreferServerCipherSuites bool // SessionTicketsDisabled may be set to true to disable session ticket - // (resumption) support. + // (resumption) support. Note that on clients, session ticket support is + // also disabled if ClientSessionCache is nil. SessionTicketsDisabled bool // SessionTicketKey is used by TLS servers to provide session @@ -473,7 +474,7 @@ type Config struct { SessionTicketKey [32]byte // ClientSessionCache is a cache of ClientSessionState entries for TLS - // session resumption. + // session resumption. It is only used by clients. ClientSessionCache ClientSessionCache // MinVersion contains the minimum SSL/TLS version that is acceptable.