From: Brad Fitzpatrick Date: Wed, 5 Mar 2014 22:09:03 +0000 (-0800) Subject: doc: update links in contribute.html X-Git-Tag: go1.3beta1~456 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=967901a396eb702497e1e1dbaf64987744a92a45;p=gostls13.git doc: update links in contribute.html CLA links are now redirects. Use new URLs instead. Also, use https:// links for all Google sites where the http version just redirects to https anyway. (That's all links on the page, as it turns out) LGTM=adg R=golang-codereviews, adg CC=golang-codereviews https://golang.org/cl/69980051 --- diff --git a/doc/contribute.html b/doc/contribute.html index bd0ba808d2..9c52527f91 100644 --- a/doc/contribute.html +++ b/doc/contribute.html @@ -22,7 +22,7 @@ you're working on if you want it to become part of the main repository.

Before undertaking to write something new for the Go project, send -mail to the mailing +mail to the mailing list to discuss what you plan to do. This gives everyone a chance to validate the design, helps prevent duplication of effort, and ensures that the idea fits inside the goals for the language @@ -135,7 +135,7 @@ are inside $GOROOT when issuing commands. Windows users may need to perform extra steps to get the code review extension working. See the CodeReview page -on the Go Wiki for details. +on the Go Wiki for details.

Log in to the code review site.

@@ -146,7 +146,7 @@ The code review server uses a Google Account to authenticate. sign in at google.com, you can use it to sign in to the code review server.) The email address you use on the Code Review site -will be recorded in the Mercurial change log +will be recorded in the Mercurial change log and in the CONTRIBUTORS file. You can create a Google Account associated with any address where you receive email. @@ -165,7 +165,7 @@ Saving authentication cookies to /Users/rsc/.codereview_upload_cookies_coderevie

Configure your account settings.

-

Edit your code review settings. +

Edit your code review settings. Grab a nickname. Many people prefer to set the Context option to “Whole file” to see more context when reviewing changes. @@ -240,7 +240,7 @@ These can be code review nicknames or arbitrary email addresses. Unless explicitly told otherwise, such as in the discussion leading up to sending in the change list, leave the reviewer field blank. This means that the -golang-codereviews@googlegroups.com +golang-codereviews@googlegroups.com mailing list will be used as the reviewer.

@@ -286,11 +286,11 @@ Files:

The special sentence “Fixes issue 159.” associates -the change with issue 159 in the Go issue tracker. +the change with issue 159 in the Go issue tracker. When this change is eventually submitted, the issue tracker will automatically mark the issue as fixed. (These conventions are described in detail by the -Google Project Hosting Issue Tracker documentation.) +Google Project Hosting Issue Tracker documentation.)

@@ -302,7 +302,7 @@ which hg change will print, something like: 

-CL created: http://codereview.appspot.com/99999
+CL created: https://codereview.appspot.com/99999

Adding or removing files from an existing change

@@ -601,7 +601,7 @@ local repository out of date; must sync before submit

Files in the Go repository don't list author names, both to avoid clutter and to avoid having to keep the lists up to date. -Instead, your name will appear in the Mercurial change log +Instead, your name will appear in the Mercurial change log and in the CONTRIBUTORS file and perhaps the AUTHORS file.

@@ -616,13 +616,15 @@ In order for them to do that, you need to have completed one of the contributor license agreements: