From: Michael Pratt Date: Mon, 4 Mar 2024 18:20:43 +0000 (-0500) Subject: cmd/preprofile: drop output directory check X-Git-Tag: go1.23rc1~758 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=979b34b37c7af73742550ff128d162d0eb2a5f2d;p=gostls13.git cmd/preprofile: drop output directory check This check serves only to provide a more descriptive error if the output directory doesn't exist. That isn't useless, but I don't see why this tool specifically should do this when no other part of the toolchain does. For #58102. Change-Id: I01cf9db2cc1dad85c3afd8a6b008c53f26cb877a Reviewed-on: https://go-review.googlesource.com/c/go/+/569336 Reviewed-by: Cherry Mui LUCI-TryBot-Result: Go LUCI --- diff --git a/src/cmd/preprofile/main.go b/src/cmd/preprofile/main.go index ec42ceea22..5b7c564081 100644 --- a/src/cmd/preprofile/main.go +++ b/src/cmd/preprofile/main.go @@ -19,7 +19,6 @@ import ( "internal/profile" "log" "os" - "path/filepath" "strconv" ) @@ -132,21 +131,11 @@ func preprocess(profileFile string, outputFile string, verbose bool) error { if outputFile == "" { fNodeMap = os.Stdout } else { - dirPath := filepath.Dir(outputFile) - _, err := os.Stat(dirPath) - if err != nil { - return fmt.Errorf("directory does not exist: %s", dirPath) - } - base := filepath.Base(outputFile) - outputFile = filepath.Join(dirPath, base) - - // write out NodeMap to a file fNodeMap, err = os.Create(outputFile) if err != nil { return fmt.Errorf("Error creating output file: %w", err) } - - defer fNodeMap.Close() // Close the file when done writing + defer fNodeMap.Close() } w := bufio.NewWriter(fNodeMap)