From: qmuntal <quimmuntal@gmail.com>
Date: Thu, 30 Mar 2023 09:04:48 +0000 (+0200)
Subject: net: unskip TestConcurrentPreferGoResolversDial on Windows
X-Git-Tag: go1.21rc1~1070
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=99159cda330e8f71b9e7e5a5287d0f8395836d4c;p=gostls13.git

net: unskip TestConcurrentPreferGoResolversDial on Windows

Windows resolver uses the Dial function since CL 409234.

Change-Id: Id631a84d2b85fc4f8897e413a0a454cf54c00de4
Reviewed-on: https://go-review.googlesource.com/c/go/+/480418
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Quim Muntal <quimmuntal@gmail.com>
---

diff --git a/src/net/lookup_test.go b/src/net/lookup_test.go
index 0868b1f083..dfcf62b1c4 100644
--- a/src/net/lookup_test.go
+++ b/src/net/lookup_test.go
@@ -1028,10 +1028,10 @@ func (lcr *lookupCustomResolver) dial() func(ctx context.Context, network, addre
 // TestConcurrentPreferGoResolversDial tests that multiple resolvers with the
 // PreferGo option used concurrently are all dialed properly.
 func TestConcurrentPreferGoResolversDial(t *testing.T) {
-	// The windows and plan9 implementation of the resolver does not use
-	// the Dial function.
 	switch runtime.GOOS {
-	case "windows", "plan9":
+	case "plan9":
+		// TODO: plan9 implementation of the resolver uses the Dial function since
+		// https://go.dev/cl/409234, this test could probably be reenabled.
 		t.Skipf("skip on %v", runtime.GOOS)
 	}