From: Jay Conrod Date: Thu, 3 Jan 2019 23:33:36 +0000 (-0500) Subject: cmd/go: fix failure in TestScript/build_runtime_gcflags X-Git-Tag: go1.12beta2~43 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=9a7278ae47fd2ef9675e4303409e726e429d64e3;p=gostls13.git cmd/go: fix failure in TestScript/build_runtime_gcflags This test case failed on the longtest builder. It relied on runtime/internal/atomic not being compiled with the -l flag in the cache. The test case now creates its own GOCACHE, similar to build_cache_compile and a few others. Also, mention the correct issue the test case verifies. Fixes #29395 Change-Id: Id50e9dfc50db03fb11582d3dd6b69c3e1ed750eb Reviewed-on: https://go-review.googlesource.com/c/156237 Run-TryBot: Jay Conrod TryBot-Result: Gobot Gobot Reviewed-by: Ian Lance Taylor --- diff --git a/src/cmd/go/testdata/script/build_runtime_gcflags.txt b/src/cmd/go/testdata/script/build_runtime_gcflags.txt index dc0767c569..767b768b82 100644 --- a/src/cmd/go/testdata/script/build_runtime_gcflags.txt +++ b/src/cmd/go/testdata/script/build_runtime_gcflags.txt @@ -1,4 +1,8 @@ -# This test verifies the standard library (specifically runtime/internal/atomic) -# can be built with -gcflags when -n is given. See golang.org/issue/26092. +# Set up fresh GOCACHE. +env GOCACHE=$WORK/gocache +mkdir $GOCACHE + +# Verify the standard library (specifically runtime/internal/atomic) can be +# built with -gcflags when -n is given. See golang.org/issue/29346. go build -n -gcflags=all='-l' std stderr 'compile.* -l .* runtime/internal/atomic'