From: Russ Cox Date: Fri, 4 Dec 2009 01:23:11 +0000 (-0800) Subject: codereview: do not gofmt deleted files X-Git-Tag: weekly.2009-12-07~40 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=9a86cc679a5a017af16d2021433754cf5c4495e9;p=gostls13.git codereview: do not gofmt deleted files R=r https://golang.org/cl/164083 --- diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py index 5daad8ee79..fa535d634d 100644 --- a/lib/codereview/codereview.py +++ b/lib/codereview/codereview.py @@ -622,6 +622,7 @@ def CheckGofmt(ui, repo, files, just_warn=False): return cwd = os.getcwd() files = [RelativePath(repo.root + '/' + f, cwd) for f in files] + files = [f for f in files if os.access(f, 0)] try: cmd = subprocess.Popen(["gofmt", "-l"] + files, shell=False, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE, close_fds=True) cmd.stdin.close()