From: Brad Fitzpatrick Date: Mon, 13 Jan 2014 21:52:06 +0000 (-0800) Subject: net/http: clarify semantics of File methods X-Git-Tag: go1.3beta1~994 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=9c4303397756b2217971465c6b2f54bbefeed37a;p=gostls13.git net/http: clarify semantics of File methods There were no docs explaining the meaning of Readdir's count argument, for instance. Clarify that these mean the same as the methods on *os.File. R=golang-codereviews, minux.ma CC=golang-codereviews https://golang.org/cl/51630043 --- diff --git a/src/pkg/net/http/fs.go b/src/pkg/net/http/fs.go index 8b32ca1d0e..042e6da113 100644 --- a/src/pkg/net/http/fs.go +++ b/src/pkg/net/http/fs.go @@ -52,12 +52,14 @@ type FileSystem interface { // A File is returned by a FileSystem's Open method and can be // served by the FileServer implementation. +// +// The methods should behave the same as those on an *os.File. type File interface { - Close() error - Stat() (os.FileInfo, error) + io.Closer + io.Reader Readdir(count int) ([]os.FileInfo, error) - Read([]byte) (int, error) Seek(offset int64, whence int) (int64, error) + Stat() (os.FileInfo, error) } func dirList(w ResponseWriter, f File) {