From: Evan Shaw <chickencha@gmail.com>
Date: Fri, 16 Apr 2010 02:53:35 +0000 (-0700)
Subject: exp/eval: Always read float literals as base 10
X-Git-Tag: weekly.2010-04-27~82
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=9ca10b0a5cc7b99c5a9f8f8f26c8e1bd5e07d703;p=gostls13.git

exp/eval: Always read float literals as base 10

We were letting bignum decide, which caused problems with float literals with a leading 0.

R=gri
CC=golang-dev
https://golang.org/cl/816047
---

diff --git a/src/pkg/exp/eval/expr.go b/src/pkg/exp/eval/expr.go
index 8651b07806..81e9ffa935 100644
--- a/src/pkg/exp/eval/expr.go
+++ b/src/pkg/exp/eval/expr.go
@@ -762,7 +762,7 @@ func (a *exprInfo) compileCharLit(lit string) *expr {
 }
 
 func (a *exprInfo) compileFloatLit(lit string) *expr {
-	f, _, n := bignum.RatFromString(lit, 0)
+	f, _, n := bignum.RatFromString(lit, 10)
 	if n != len(lit) {
 		log.Crashf("malformed float literal %s at %v passed parser", lit, a.pos)
 	}
diff --git a/src/pkg/exp/eval/expr_test.go b/src/pkg/exp/eval/expr_test.go
index f7f367d5e9..12914fbd54 100644
--- a/src/pkg/exp/eval/expr_test.go
+++ b/src/pkg/exp/eval/expr_test.go
@@ -142,6 +142,7 @@ var exprTests = []test{
 
 	Val("+1", bignum.Int(+1)),
 	Val("+1.0", bignum.Rat(1, 1)),
+	Val("01.5", bignum.Rat(15, 10)),
 	CErr("+\"x\"", opTypes),
 
 	Val("-42", bignum.Int(-42)),