From: Ian Lance Taylor Date: Wed, 26 Feb 2025 05:44:25 +0000 (-0800) Subject: cmd/link: require cgo for -linkmode=external test X-Git-Tag: go1.25rc1~892 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=9cceaf87361d0b797dd23ec7467d9adb62910fc9;p=gostls13.git cmd/link: require cgo for -linkmode=external test For #71416 Fixes #71957 Change-Id: I2180dada34d9dd2d3f5b0aaf8525951fd2e86a27 Reviewed-on: https://go-review.googlesource.com/c/go/+/652277 Reviewed-by: Michael Pratt Reviewed-by: Quim Muntal LUCI-TryBot-Result: Go LUCI Auto-Submit: Ian Lance Taylor Reviewed-by: Cherry Mui --- diff --git a/src/cmd/link/internal/ld/macho_test.go b/src/cmd/link/internal/ld/macho_test.go index 1a4ffd8eb8..253abd30a4 100644 --- a/src/cmd/link/internal/ld/macho_test.go +++ b/src/cmd/link/internal/ld/macho_test.go @@ -40,10 +40,11 @@ func TestMachoSectionsReadOnly(t *testing.T) { wantSecsRO: []string{"__nl_symbol_ptr", "__rodata", "__itablink", "__typelink", "__gosymtab", "__gopclntab"}, }, { - name: "linkmode-external", - args: []string{"-ldflags", "-linkmode=external"}, - prog: prog, - wantSecsRO: []string{"__got", "__rodata", "__itablink", "__typelink", "__gopclntab"}, + name: "linkmode-external", + args: []string{"-ldflags", "-linkmode=external"}, + prog: prog, + mustHaveCGO: true, + wantSecsRO: []string{"__got", "__rodata", "__itablink", "__typelink", "__gopclntab"}, }, { name: "cgo-linkmode-internal",