From: Michael Pratt <mpratt@google.com>
Date: Fri, 21 Jan 2022 16:07:52 +0000 (-0500)
Subject: runtime/pprof: TestLabelSystemstack parallelLabelHog.func1 must be labeled
X-Git-Tag: go1.18beta2~55
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=9eba5ff5219a76c3c4e020fa27e966a226174d7e;p=gostls13.git

runtime/pprof: TestLabelSystemstack parallelLabelHog.func1 must be labeled

The closure in parallelLabelHog should be labeled in a addition to
parallelLabelHog itself. Generally samples on that goroutine land on
labelHog, but there is a small portion of the closure outside of
labelHog.

Fixes #50740.

Change-Id: I363b6d8eec2e6920c215686e2039fce6d5b29a98
Reviewed-on: https://go-review.googlesource.com/c/go/+/380055
Reviewed-by: Bryan Mills <bcmills@google.com>
Trust: Michael Pratt <mpratt@google.com>
---

diff --git a/src/runtime/pprof/pprof_test.go b/src/runtime/pprof/pprof_test.go
index 19b9754e8b..1a44ab7ad7 100644
--- a/src/runtime/pprof/pprof_test.go
+++ b/src/runtime/pprof/pprof_test.go
@@ -1448,7 +1448,7 @@ func TestLabelSystemstack(t *testing.T) {
 		for _, loc := range s.Location {
 			for _, l := range loc.Line {
 				switch l.Function.Name {
-				case "runtime/pprof.labelHog", "runtime/pprof.parallelLabelHog":
+				case "runtime/pprof.labelHog", "runtime/pprof.parallelLabelHog", "runtime/pprof.parallelLabelHog.func1":
 					mustBeLabeled = true
 				case "runtime/pprof.Do":
 					// Do sets the labels, so samples may