From: Brad Fitzpatrick <bradfitz@golang.org>
Date: Mon, 20 Jun 2011 21:36:03 +0000 (-0700)
Subject: http: write Header keys with empty values
X-Git-Tag: weekly.2011-06-23~36
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=9ee83f546fb1febfb580030c8c6e5d2eebe721d2;p=gostls13.git

http: write Header keys with empty values

R=golang-dev, rsc, r
CC=golang-dev
https://golang.org/cl/4630052
---

diff --git a/src/pkg/http/header.go b/src/pkg/http/header.go
index 95140b01f2..95a25a814b 100644
--- a/src/pkg/http/header.go
+++ b/src/pkg/http/header.go
@@ -62,9 +62,6 @@ func (h Header) WriteSubset(w io.Writer, exclude map[string]bool) os.Error {
 			v = strings.Replace(v, "\n", " ", -1)
 			v = strings.Replace(v, "\r", " ", -1)
 			v = strings.TrimSpace(v)
-			if v == "" {
-				continue
-			}
 			if _, err := fmt.Fprintf(w, "%s: %s\r\n", k, v); err != nil {
 				return err
 			}
diff --git a/src/pkg/http/header_test.go b/src/pkg/http/header_test.go
index 7e24cb069c..ccdee8a97b 100644
--- a/src/pkg/http/header_test.go
+++ b/src/pkg/http/header_test.go
@@ -57,6 +57,16 @@ var headerWriteTests = []struct {
 		map[string]bool{"Content-Length": true, "Expires": true, "Content-Encoding": true},
 		"",
 	},
+	{
+		Header{
+			"Nil":          nil,
+			"Empty":        {},
+			"Blank":        {""},
+			"Double-Blank": {"", ""},
+		},
+		nil,
+		"Blank: \r\nDouble-Blank: \r\nDouble-Blank: \r\n",
+	},
 }
 
 func TestHeaderWrite(t *testing.T) {