From: Joel Sing Date: Mon, 9 Mar 2020 16:27:44 +0000 (+1100) Subject: cmd/compile: remove special handling for OpRISCV64SUBW in markUnsafePoints X-Git-Tag: go1.15beta1~908 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=9f74f0afa6270e6735c1b6f59519cc88ff2ed1e4;p=gostls13.git cmd/compile: remove special handling for OpRISCV64SUBW in markUnsafePoints Due to improved optimisation, we no longer emit SUBW for the write barrier checks on riscv64, hence remove special handling in markUnsafePoints. Change-Id: Ia1150c3e11f25e183735e58f8716a511d9e90fb3 Reviewed-on: https://go-review.googlesource.com/c/go/+/222638 Reviewed-by: Keith Randall Reviewed-by: Cherry Zhang --- diff --git a/src/cmd/compile/internal/gc/plive.go b/src/cmd/compile/internal/gc/plive.go index f8f7de0a95..845b2bd724 100644 --- a/src/cmd/compile/internal/gc/plive.go +++ b/src/cmd/compile/internal/gc/plive.go @@ -705,12 +705,6 @@ func (lv *Liveness) markUnsafePoints() { v = v.Args[0] continue } - case ssa.OpRISCV64SUBW: - // RISCV64 lowers Neq32 to include a SUBW with multiple arguments. - // TODO(jsing): it would be preferable not to use Neq32 for - // writeBuffer.enabled checks on this platform. - v = v.Args[0] - continue case ssa.Op386MOVLload, ssa.OpARM64MOVWUload, ssa.OpPPC64MOVWZload, ssa.OpWasmI64Load32U: // Args[0] is the address of the write // barrier control. Ignore Args[1],