From: Aman Gupta Date: Thu, 11 Apr 2019 23:20:27 +0000 (-0700) Subject: cmd/link/internal/ld: improve messages for testDWARF failures X-Git-Tag: go1.13beta1~181 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=a0c96a926122f4437f0eba8ae42cc0369511cb58;p=gostls13.git cmd/link/internal/ld: improve messages for testDWARF failures Change-Id: I60af7a6477d1b25c43b311246ae4a79bf691460e Reviewed-on: https://go-review.googlesource.com/c/go/+/171819 Reviewed-by: Brad Fitzpatrick Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- diff --git a/src/cmd/link/dwarf_test.go b/src/cmd/link/dwarf_test.go index e52e26af49..9c411ff1b8 100644 --- a/src/cmd/link/dwarf_test.go +++ b/src/cmd/link/dwarf_test.go @@ -93,11 +93,11 @@ func testDWARF(t *testing.T, buildmode string, expectDWARF bool, env ...string) // Ensure Apple's tooling can parse our object for symbols. out, err = exec.Command("symbols", exe).CombinedOutput() if err != nil { - t.Fatal(err) + t.Fatalf("symbols %v: %v: %s", filepath.Base(exe), err, out) } else { if bytes.HasPrefix(out, []byte("Unable to find file")) { // This failure will cause the App Store to reject our binaries. - t.Fatalf("/usr/bin/symbols %v: failed to parse file", filepath.Base(exe)) + t.Fatalf("symbols %v: failed to parse file", filepath.Base(exe)) } } }