From: Rob Pike <r@golang.org>
Date: Wed, 17 Oct 2018 11:32:27 +0000 (+1100)
Subject: cmd/doc: fix repeated header bug added in previous CL
X-Git-Tag: go1.12beta1~747
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=a2381f59662f8118c5cd78baaa90e8b186947e8f;p=gostls13.git

cmd/doc: fix repeated header bug added in previous CL

One too many lines was deleted, and it would print a header multiple times.
Add a test.

Change-Id: I4906b454dbb66193d515ffacf43849ffdc2dede6
Reviewed-on: https://go-review.googlesource.com/c/142937
Reviewed-by: Ralph Corderoy <ralph@inputplus.co.uk>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
---

diff --git a/src/cmd/doc/doc_test.go b/src/cmd/doc/doc_test.go
index 80fdb5c72e..ec3a50d87d 100644
--- a/src/cmd/doc/doc_test.go
+++ b/src/cmd/doc/doc_test.go
@@ -733,6 +733,9 @@ func TestDoc(t *testing.T) {
 				failed = true
 			}
 		}
+		if bytes.Count(output, []byte("TYPES\n")) > 1 {
+			t.Fatalf("%s: repeating headers", test.name)
+		}
 		if failed {
 			t.Logf("\n%s", output)
 		}
diff --git a/src/cmd/doc/pkg.go b/src/cmd/doc/pkg.go
index bb1b998537..680f555f59 100644
--- a/src/cmd/doc/pkg.go
+++ b/src/cmd/doc/pkg.go
@@ -426,6 +426,7 @@ func (pkg *Package) allDoc() {
 	printHdr := func(s string) {
 		if hdr != s {
 			pkg.Printf("\n%s\n\n", s)
+			hdr = s
 		}
 	}