From: Brad Fitzpatrick Date: Wed, 12 Dec 2012 19:33:03 +0000 (-0800) Subject: misc/dashboard: don't email about netbsd failures X-Git-Tag: go1.1rc2~1650 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=a257c753ac151d654d40258f11fdcda5dba7f779;p=gostls13.git misc/dashboard: don't email about netbsd failures Too flaky. R=iant, rsc CC=golang-dev https://golang.org/cl/6925056 --- diff --git a/misc/dashboard/app/build/notify.go b/misc/dashboard/app/build/notify.go index afcc7b2db5..0eadb909f3 100644 --- a/misc/dashboard/app/build/notify.go +++ b/misc/dashboard/app/build/notify.go @@ -21,6 +21,13 @@ const ( domain = "build.golang.org" ) +// failIgnore is a set of builders that we don't email about because +// they're too flaky. +var failIgnore = map[string]bool{ + "netbsd-386-bsiegert": true, + "netbsd-amd64-bsiegert": true, +} + // notifyOnFailure checks whether the supplied Commit or the subsequent // Commit (if present) breaks the build for this builder. // If either of those commits break the build an email notification is sent @@ -30,6 +37,10 @@ const ( // This must be run in a datastore transaction, and the provided *Commit must // have been retrieved from the datastore within that transaction. func notifyOnFailure(c appengine.Context, com *Commit, builder string) error { + if failIgnore[builder] { + return + } + // TODO(adg): implement notifications for packages if com.PackagePath != "" { return nil