From: Daniel McCarney <daniel@binaryparadox.net>
Date: Thu, 21 Nov 2024 18:11:07 +0000 (-0500)
Subject: cmd/dist: skip FIPS 140-3 testing
X-Git-Tag: go1.24rc1~139
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=a3a31ec8ed4aff33d9f5ef8358f9f74efb249f74;p=gostls13.git

cmd/dist: skip FIPS 140-3 testing

This will be re-enabled by an in-progress CR. For now, ignore this test
process to prevent build breakage.

Change-Id: Ica1cb1c4f9844164ab32767ce2a499021d40b997
Reviewed-on: https://go-review.googlesource.com/c/go/+/630237
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Auto-Submit: Filippo Valsorda <filippo@golang.org>
---

diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go
index 59a5e42b5b..cd3c30da0b 100644
--- a/src/cmd/dist/test.go
+++ b/src/cmd/dist/test.go
@@ -715,13 +715,14 @@ func (t *tester) registerTests() {
 
 	// Check that all crypto packages compile (and test correctly, in longmode) with fips.
 	if fipsSupported() {
+		/* TODO(cpu): Restore in #629736
 		// Test standard crypto packages with fips140=on.
 		t.registerTest("GODEBUG=fips140=on go test crypto/...", &goTest{
 			variant: "gofips140",
 			env:     []string{"GODEBUG=fips140=on"},
-			skip:    "TestHandshake|TestServerResumption|TestClientAuth|TestRenegotiate", // TODO(valsorda): remove once crypto/tls passes
+			skip:    "TestHandshake|TestServerResumption|TestClientAuth|TestRenegotiate", // TODO(cpu): remove in #629736
 			pkg:     "crypto/...",
-		})
+		})*/
 
 		// Test that earlier FIPS snapshots build.
 		// In long mode, test that they work too.