From: Russ Cox <rsc@golang.org>
Date: Tue, 18 Oct 2016 03:19:10 +0000 (-0400)
Subject: testing: document that Skip cannot undo Error
X-Git-Tag: go1.8beta1~798
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=a431bdc712c7a404307f38228271d970d9d2c023;p=gostls13.git

testing: document that Skip cannot undo Error

Fixes #16502.

Change-Id: Id8e117a724d73cd51844c06d47bbeba61f8dc827
Reviewed-on: https://go-review.googlesource.com/31324
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
---

diff --git a/src/testing/testing.go b/src/testing/testing.go
index 7ca9d49605..3dcc5afef9 100644
--- a/src/testing/testing.go
+++ b/src/testing/testing.go
@@ -520,6 +520,7 @@ func (c *common) Skipf(format string, args ...interface{}) {
 }
 
 // SkipNow marks the test as having been skipped and stops its execution.
+// If a test fails (see Error, Errorf, Fail) and is then skipped, it is still considered to have failed.
 // Execution will continue at the next test or benchmark. See also FailNow.
 // SkipNow must be called from the goroutine running the test, not from
 // other goroutines created during the test. Calling SkipNow does not stop