From: james <james.naftel@gmail.com>
Date: Thu, 11 Apr 2019 20:18:29 +0000 (-0400)
Subject: os: don't leak file in ExampleOpenFile_append failure path
X-Git-Tag: go1.13beta1~726
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=a5032bc86c1a661cf3a68d5095c7a86591c62bc1;p=gostls13.git

os: don't leak file in ExampleOpenFile_append failure path

Fixes #31424

Change-Id: I8364578cbc77827552bd764c716f68495ec51547
Reviewed-on: https://go-review.googlesource.com/c/go/+/171763
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
---

diff --git a/src/os/example_test.go b/src/os/example_test.go
index 8b6566e149..822886f70c 100644
--- a/src/os/example_test.go
+++ b/src/os/example_test.go
@@ -28,6 +28,7 @@ func ExampleOpenFile_append() {
 		log.Fatal(err)
 	}
 	if _, err := f.Write([]byte("appended some data\n")); err != nil {
+		f.Close() // ignore error; Write error takes precedence
 		log.Fatal(err)
 	}
 	if err := f.Close(); err != nil {