From: Nigel Tao <nigeltao@golang.org>
Date: Fri, 17 Feb 2012 03:39:50 +0000 (+1100)
Subject: fix: walk ast.Ellipsis values.
X-Git-Tag: weekly.2012-02-22~167
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=a52027a491c27a057ed7413607393f5f0a256c8d;p=gostls13.git

fix: walk ast.Ellipsis values.

Fixes #2583.

R=rsc, r
CC=golang-dev
https://golang.org/cl/5671078
---

diff --git a/src/cmd/fix/error_test.go b/src/cmd/fix/error_test.go
index eeab7e2ee1..027eed24f8 100644
--- a/src/cmd/fix/error_test.go
+++ b/src/cmd/fix/error_test.go
@@ -42,6 +42,10 @@ func g() {
 	error := 1
 	_ = error
 }
+
+func h(os.Error) {}
+
+func i(...os.Error) {}
 `,
 		Out: `package main
 
@@ -59,6 +63,10 @@ func g() {
 	error := 1
 	_ = error
 }
+
+func h(error) {}
+
+func i(...error) {}
 `,
 	},
 	{
diff --git a/src/cmd/fix/fix.go b/src/cmd/fix/fix.go
index d2067cb51e..a100be794e 100644
--- a/src/cmd/fix/fix.go
+++ b/src/cmd/fix/fix.go
@@ -113,6 +113,7 @@ func walkBeforeAfter(x interface{}, before, after func(interface{})) {
 	case *ast.BadExpr:
 	case *ast.Ident:
 	case *ast.Ellipsis:
+		walkBeforeAfter(&n.Elt, before, after)
 	case *ast.BasicLit:
 	case *ast.FuncLit:
 		walkBeforeAfter(&n.Type, before, after)