From: empijei <robclap8@gmail.com>
Date: Wed, 16 Oct 2019 04:56:10 +0000 (+0200)
Subject: net/http: clarify Header.WriteSubset behavior
X-Git-Tag: go1.14beta1~473
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=a570fcf74bdf652f453ed5dc0d8a41b15f1af8de;p=gostls13.git

net/http: clarify Header.WriteSubset behavior

The current implementation performs a plain map lookup,
but other header methods canonicalize header keys before
using them.

Fixes #34918

Change-Id: Id4120488b8b39ecee97fa7a6ad8a34158687ffcd
Reviewed-on: https://go-review.googlesource.com/c/go/+/201357
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
---

diff --git a/src/net/http/header.go b/src/net/http/header.go
index 4a4ebbcf2f..b9b53911f3 100644
--- a/src/net/http/header.go
+++ b/src/net/http/header.go
@@ -178,6 +178,7 @@ func (h Header) sortedKeyValues(exclude map[string]bool) (kvs []keyValues, hs *h
 
 // WriteSubset writes a header in wire format.
 // If exclude is not nil, keys where exclude[key] == true are not written.
+// Keys are not canonicalized before checking the exclude map.
 func (h Header) WriteSubset(w io.Writer, exclude map[string]bool) error {
 	return h.writeSubset(w, exclude, nil)
 }