From: Clément Chigot Date: Thu, 11 Jul 2019 07:43:38 +0000 (+0200) Subject: net: set TestNotTemporaryRead flaky for AIX X-Git-Tag: go1.13rc1~104 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=a5f3823c27d93f16dfde56509071a20130e0c731;p=gostls13.git net: set TestNotTemporaryRead flaky for AIX This test sometimes times out when the machine is busy. The reason behind is still a bit blurry. But it seems to comes from the fact that on AIX, once a listen is performed a socket, every connection will be accepted even before an accept is made (which only occurs when a machine is busy). On Linux, a socket is created as a "passive socket" which seems to wait for the accept before allowing incoming connections. Updates #29685 Change-Id: I41b053b7d5f5b4420b72d6a217be72e41220d769 Reviewed-on: https://go-review.googlesource.com/c/go/+/185717 Run-TryBot: Clément Chigot Reviewed-by: Ian Lance Taylor --- diff --git a/src/net/net_test.go b/src/net/net_test.go index 2b5845bb15..463ae8856d 100644 --- a/src/net/net_test.go +++ b/src/net/net_test.go @@ -525,6 +525,9 @@ func TestNotTemporaryRead(t *testing.T) { if runtime.GOOS == "freebsd" { testenv.SkipFlaky(t, 25289) } + if runtime.GOOS == "aix" { + testenv.SkipFlaky(t, 29685) + } t.Parallel() server := func(cs *TCPConn) error { cs.SetLinger(0)