From: Tyler Bui-Palsulich Date: Wed, 13 Sep 2017 15:09:21 +0000 (-0700) Subject: container/heap: call t.Helper() in verify() X-Git-Tag: go1.10beta1~1114 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=a696277243fdb8049de8e1b10ce6144a69b12c61;p=gostls13.git container/heap: call t.Helper() in verify() I modified verify() to fail every time to test the change. Before adding t.Helper() (line 37 is in verify()): /.../go/src/container/heap/heap_test.go:37: forced failure FAIL Afer adding t.Helper() (line 67 is where verify() is called): /.../go/src/container/heap/heap_test.go:67: forced failure FAIL Fixes #21863 Change-Id: I46f0c8ec413cc664358c568fc53e48bb4a1d03d0 Reviewed-on: https://go-review.googlesource.com/63570 Reviewed-by: Brad Fitzpatrick Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- diff --git a/src/container/heap/heap_test.go b/src/container/heap/heap_test.go index d41110422e..f19f9cfa74 100644 --- a/src/container/heap/heap_test.go +++ b/src/container/heap/heap_test.go @@ -33,6 +33,7 @@ func (h *myHeap) Push(v interface{}) { } func (h myHeap) verify(t *testing.T, i int) { + t.Helper() n := h.Len() j1 := 2*i + 1 j2 := 2*i + 2