From: Brad Fitzpatrick Date: Sat, 16 Jul 2016 23:56:45 +0000 (+0000) Subject: net: demote TestDialerDualStack to a flaky test X-Git-Tag: go1.7rc3~1^2~14 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=a6dbfc12c640c90e8dc552443d3ece04cbae4a9c;p=gostls13.git net: demote TestDialerDualStack to a flaky test Only run TestDialerDualStack on the builders, as to not annoy or otherwise distract users when it's not their fault. Even though the intention is to only run this on the builders, very few of the builders have IPv6 support. Oh well. We'll get some coverage. Updates #13324 Change-Id: I13e7e3bca77ac990d290cabec88984cc3d24fb67 Reviewed-on: https://go-review.googlesource.com/24985 Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot Reviewed-by: Mikio Hara --- diff --git a/src/net/dial_test.go b/src/net/dial_test.go index 9fe507e901..8b21e6b088 100644 --- a/src/net/dial_test.go +++ b/src/net/dial_test.go @@ -695,6 +695,11 @@ func TestDialerLocalAddr(t *testing.T) { } func TestDialerDualStack(t *testing.T) { + // This test is known to be flaky. Don't frighten regular + // users about it; only fail on the build dashboard. + if testenv.Builder() == "" { + testenv.SkipFlaky(t, 13324) + } if !supportsIPv4 || !supportsIPv6 { t.Skip("both IPv4 and IPv6 are required") }