From: Martin Möhrmann <moehrmann@google.com>
Date: Wed, 17 Jan 2018 20:00:26 +0000 (+0100)
Subject: cmd/compile: replace range loop over list of nodes with orderexprlistinplace
X-Git-Tag: go1.11beta1~1648
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=a90fc6d2d4b7a1a054de50841a8bebfc2c2668e9;p=gostls13.git

cmd/compile: replace range loop over list of nodes with orderexprlistinplace

Replace explicit range loop that applies orderexprinplace on a
list of nodes with existing helper function orderexprlistinplace.

Passes toolstash -cmp.

Change-Id: Ic8098ed08cf67f319de3faa83b00a5b73bbde95d
Reviewed-on: https://go-review.googlesource.com/88815
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
---

diff --git a/src/cmd/compile/internal/gc/order.go b/src/cmd/compile/internal/gc/order.go
index 39e36f7c09..b0115fe733 100644
--- a/src/cmd/compile/internal/gc/order.go
+++ b/src/cmd/compile/internal/gc/order.go
@@ -762,9 +762,7 @@ func orderstmt(n *Node, order *Order) {
 			// hiter contains pointers and needs to be zeroed.
 			prealloc[n] = ordertemp(hiter(n.Type), order, true)
 		}
-		for i, n1 := range n.List.Slice() {
-			n.List.SetIndex(i, orderexprinplace(n1, order))
-		}
+		orderexprlistinplace(n.List, order)
 		orderblockNodes(&n.Nbody)
 		order.out = append(order.out, n)
 		cleantemp(t, order)