From: David Chase Date: Mon, 26 Mar 2018 17:37:00 +0000 (-0400) Subject: cmd/compile: invoke gdb more carefully in ssa/debug_test.go X-Git-Tag: go1.11beta1~1101 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=a934e34e875d6402da79d52a859434b60b6f6131;p=gostls13.git cmd/compile: invoke gdb more carefully in ssa/debug_test.go Gdb can be sensitive to contents of .gdbinit, and to run this test properly needs to have runtime/runtime-gdb.py on the auto load safe path. Therefore, turn off .gdbinit loading and explicitly add $GOROOT/runtime to the safe load path. This should make ssa/debug_test.go run more consistently. Updates #24464. Change-Id: I63ed17c032cb3773048713ce51fca3a3f86e79b6 Reviewed-on: https://go-review.googlesource.com/102598 Run-TryBot: David Chase TryBot-Result: Gobot Gobot Reviewed-by: Ian Lance Taylor --- diff --git a/src/cmd/compile/internal/ssa/debug_test.go b/src/cmd/compile/internal/ssa/debug_test.go index ff9f17525b..d0a7a69db9 100644 --- a/src/cmd/compile/internal/ssa/debug_test.go +++ b/src/cmd/compile/internal/ssa/debug_test.go @@ -551,7 +551,9 @@ type gdbState struct { func newGdb(tag, executable string, args ...string) dbgr { // Turn off shell, necessary for Darwin apparently - cmd := exec.Command(gdb, "-ex", "set startup-with-shell off", executable) + cmd := exec.Command(gdb, "-nx", + "-iex", fmt.Sprintf("add-auto-load-safe-path %s/src/runtime", runtime.GOROOT()), + "-ex", "set startup-with-shell off", executable) cmd.Env = replaceEnv(cmd.Env, "TERM", "dumb") s := &gdbState{tagg: tag, cmd: cmd, args: args} s.atLineRe = regexp.MustCompile("(^|\n)([0-9]+)(.*)")