From: Matthew Dempsky <mdempsky@google.com>
Date: Tue, 22 Oct 2019 00:06:02 +0000 (-0700)
Subject: sync/atomic: suppress checkptr errors for hammerStoreLoadPointer
X-Git-Tag: go1.14beta1~641
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=a97ccc894032d646e3003f061704ca59cac2587f;p=gostls13.git

sync/atomic: suppress checkptr errors for hammerStoreLoadPointer

This test could be updated to use unsafe.Pointer arithmetic properly
(e.g., see discussion at #34972), but it doesn't seem worthwhile. The
test is just checking that LoadPointer and StorePointer are atomic.

Updates #34972.

Change-Id: I85a8d610c1766cd63136cae686aa8a240a362a18
Reviewed-on: https://go-review.googlesource.com/c/go/+/202597
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
---

diff --git a/src/sync/atomic/atomic_test.go b/src/sync/atomic/atomic_test.go
index 135f02a726..286eadc6cd 100644
--- a/src/sync/atomic/atomic_test.go
+++ b/src/sync/atomic/atomic_test.go
@@ -1140,6 +1140,9 @@ func hammerStoreLoadUintptr(t *testing.T, paddr unsafe.Pointer) {
 	StoreUintptr(addr, new)
 }
 
+//go:nocheckptr
+// This code is just testing that LoadPointer/StorePointer operate
+// atomically; it's not actually calculating pointers.
 func hammerStoreLoadPointer(t *testing.T, paddr unsafe.Pointer) {
 	addr := (*unsafe.Pointer)(paddr)
 	v := uintptr(LoadPointer(addr))