From: Andrew Gerrand <adg@golang.org>
Date: Fri, 3 Feb 2012 03:03:46 +0000 (+1100)
Subject: dashboard: don't send failing Go commits as todos for subrepos
X-Git-Tag: weekly.2012-02-07~109
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=aa716e36a6c0656730eeab753eaba9d07aab72e0;p=gostls13.git

dashboard: don't send failing Go commits as todos for subrepos

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5608044
---

diff --git a/misc/dashboard/app/build/handler.go b/misc/dashboard/app/build/handler.go
index 4aa161e8d2..c74c54a98f 100644
--- a/misc/dashboard/app/build/handler.go
+++ b/misc/dashboard/app/build/handler.go
@@ -215,10 +215,22 @@ func buildTodo(c appengine.Context, builder, packagePath, goHash string) (interf
 	// see if there are any subrepo commits that need to be built at tip.
 	// If so, ask the builder to build a go tree at the tip commit.
 	// TODO(adg): do the same for "weekly" and "release" tags.
+
 	tag, err := GetTag(c, "tip")
 	if err != nil {
 		return nil, err
 	}
+
+	// Check that this Go commit builds OK for this builder.
+	// If not, don't re-build as the subrepos will never get built anyway.
+	com, err := tag.Commit(c)
+	if err != nil {
+		return nil, err
+	}
+	if r := com.Result(builder, ""); r != nil && !r.OK {
+		return nil, nil
+	}
+
 	pkgs, err := Packages(c, "subrepo")
 	if err != nil {
 		return nil, err
@@ -233,6 +245,7 @@ func buildTodo(c appengine.Context, builder, packagePath, goHash string) (interf
 			return tag.Commit(c)
 		}
 	}
+
 	return nil, nil
 }