From: Keith Randall <khr@golang.org>
Date: Tue, 8 Dec 2020 22:35:41 +0000 (-0800)
Subject: doc: add description of new framepointer vet check
X-Git-Tag: go1.16beta1~64
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=ae9b442df2;p=gostls13.git

doc: add description of new framepointer vet check

Update #43014

Change-Id: I5fbfaa16e6acb8859fd0b1188f532f5a225f6349
Reviewed-on: https://go-review.googlesource.com/c/go/+/276373
Trust: Keith Randall <khr@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
---

diff --git a/doc/go1.16.html b/doc/go1.16.html
index 012be1656f..504165f3ea 100644
--- a/doc/go1.16.html
+++ b/doc/go1.16.html
@@ -293,6 +293,18 @@ Do not send CLs removing the interior tags from such phrases.
   <!-- CL 235677: https://golang.org/cl/235677: cmd/vet: bring in pass to catch invalid uses of testing.T in goroutines -->
 </p>
 
+<p><!-- CL 248686, CL 276372 -->
+  The vet tool now warns about amd64 assembly that clobbers the BP
+  register (the frame pointer) without saving and restoring it,
+  contrary to the calling convention. Code that doesn't preserve the
+  BP register must be modified to either not use BP at all or preserve
+  BP by saving and restoring it. An easy way to preserve BP is to set
+  the frame size to a nonzero value, which causes the generated
+  prologue and epilogue to preserve the BP register for you.
+  See <a href="https://golang.org/cl/248260">CL 248260</a> for example
+  fixes.
+</p>
+
 <h2 id="runtime">Runtime</h2>
 
 <p>