From: Rémy Oudompheng <oudomphe@phare.normalesup.org>
Date: Thu, 18 Apr 2013 06:21:15 +0000 (-0700)
Subject: crypto/rand: better panic message for invalid Int argument.
X-Git-Tag: go1.1rc2~82
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=b08a3164c0a10b608db0e9fafcdc3c9168e3cffe;p=gostls13.git

crypto/rand: better panic message for invalid Int argument.

Also document the panic to be consistent with math/rand.

Fixes #5187.

R=golang-dev, dave, bradfitz, r
CC=golang-dev
https://golang.org/cl/8303043
---

diff --git a/src/pkg/crypto/rand/util.go b/src/pkg/crypto/rand/util.go
index 21608dbaca..0cd5e0e022 100644
--- a/src/pkg/crypto/rand/util.go
+++ b/src/pkg/crypto/rand/util.go
@@ -100,8 +100,11 @@ func Prime(rand io.Reader, bits int) (p *big.Int, err error) {
 	}
 }
 
-// Int returns a uniform random value in [0, max).
+// Int returns a uniform random value in [0, max). It panics if max <= 0.
 func Int(rand io.Reader, max *big.Int) (n *big.Int, err error) {
+	if max.Sign() <= 0 {
+		panic("crypto/rand: argument to Int is <= 0")
+	}
 	k := (max.BitLen() + 7) / 8
 
 	// b is the number of bits in the most significant byte of max.