From: Daniel McCarney Date: Tue, 18 Feb 2025 17:41:34 +0000 (-0500) Subject: crypto/tls: run SkipNewSessionTicket bogo test X-Git-Tag: go1.25rc1~782 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=b0e7f95aacbfed6cca892859ec2589c3bd7cf0b8;p=gostls13.git crypto/tls: run SkipNewSessionTicket bogo test This commit removes SkipNewSessionTicket from the bogo_config.json excluded tests list. Previously this test was being skipped with a TODO that there might be a bug here. In practice it seems like there's no bug and the test is handled correctly by crypto/tls. When activated, a TLS 1.2 client connecting to the bogo dispatcher goes through the normal handshake process with the exception that the server skips sending the NewSessionTicket msg expected by the client in response to the client's final flight of handshake msgs. The crypto/tls TLS 1.2 client_handshake.go logic correctly rejects the unexpected message that follows (ChangeCipherSpec) when trying to read the bytes necessary to unmarshal the expected NewSessionTicket message that was omitted. Updates #72006 Change-Id: I9faea4d18589d10b163211aa17b2d0da8af1187e Reviewed-on: https://go-review.googlesource.com/c/go/+/650736 Reviewed-by: Junyang Shao Auto-Submit: Daniel McCarney LUCI-TryBot-Result: Go LUCI Reviewed-by: Roland Shoemaker --- diff --git a/src/crypto/tls/bogo_config.json b/src/crypto/tls/bogo_config.json index f4772a00b2..e1ace2398e 100644 --- a/src/crypto/tls/bogo_config.json +++ b/src/crypto/tls/bogo_config.json @@ -52,7 +52,6 @@ "JustConfiguringKyberWorks": "we always send a X25519 key share with Kyber", "KyberKeyShareIncludedSecond": "we always send the Kyber key share first", "KyberKeyShareIncludedThird": "we always send the Kyber key share first", - "SkipNewSessionTicket": "TODO confusing? maybe bug", "SendUserCanceledAlerts*": "TODO may be a real bug?", "GREASE-Server-TLS13": "TODO ???", "GarbageCertificate*": "TODO ask davidben, alertDecode vs alertBadCertificate",