From: Sergey Matveev <stargrave@stargrave.org>
Date: Sat, 14 Dec 2019 18:36:06 +0000 (+0300)
Subject: Fix nncp-check return code
X-Git-Tag: v5.2.0^2~3
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=b2e36aeaa5dc1c9649c6895d938208d92ddc3fa3;p=nncp.git

Fix nncp-check return code
---

diff --git a/src/check.go b/src/check.go
index fdd6436..a0f34ce 100644
--- a/src/check.go
+++ b/src/check.go
@@ -37,7 +37,7 @@ func Check(src io.Reader, checksum []byte) (bool, error) {
 	return bytes.Compare(hsh.Sum(nil), checksum) == 0, nil
 }
 
-func (ctx *Ctx) checkXx(nodeId *NodeId, xx TRxTx) bool {
+func (ctx *Ctx) checkXxIsBad(nodeId *NodeId, xx TRxTx) bool {
 	isBad := false
 	for job := range ctx.Jobs(nodeId, xx) {
 		sds := SDS{
@@ -50,7 +50,7 @@ func (ctx *Ctx) checkXx(nodeId *NodeId, xx TRxTx) bool {
 		job.Fd.Close()
 		if err != nil {
 			ctx.LogE("check", SdsAdd(sds, SDS{"err": err}), "")
-			return false
+			return true
 		}
 		if !gut {
 			isBad = true
@@ -61,5 +61,5 @@ func (ctx *Ctx) checkXx(nodeId *NodeId, xx TRxTx) bool {
 }
 
 func (ctx *Ctx) Check(nodeId *NodeId) bool {
-	return ctx.checkXx(nodeId, TRx) || ctx.checkXx(nodeId, TTx)
+	return !(ctx.checkXxIsBad(nodeId, TRx) || ctx.checkXxIsBad(nodeId, TTx))
 }