From: David Symonds <dsymonds@golang.org>
Date: Mon, 29 Oct 2012 11:03:58 +0000 (+1100)
Subject: misc/dashboard/codereview: only accept "NOT LGTM" on the first line of a message.
X-Git-Tag: go1.1rc2~2049
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=b506c3e17aad13ec64ff24d86ec034259bd224d1;p=gostls13.git

misc/dashboard/codereview: only accept "NOT LGTM" on the first line of a message.

Too many people quote entire emails and put their reply at the top ("top posting"),
so we shouldn't recognise review commands anywhere in the review text.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6815048
---

diff --git a/misc/dashboard/codereview/dashboard/cl.go b/misc/dashboard/codereview/dashboard/cl.go
index 4187ca6855..dce2744257 100644
--- a/misc/dashboard/codereview/dashboard/cl.go
+++ b/misc/dashboard/codereview/dashboard/cl.go
@@ -389,7 +389,7 @@ func updateCL(c appengine.Context, n string) error {
 			lgtm[s] = true
 			delete(notLGTM, s) // "LGTM" overrules previous "NOT LGTM"
 		}
-		if strings.Contains(msg.Text, "NOT LGTM") {
+		if strings.Contains(line, "NOT LGTM") {
 			notLGTM[s] = true
 			delete(lgtm, s) // "NOT LGTM" overrules previous "LGTM"
 		}