From: Shivakumar GN <shivakumar.gn@gmail.com>
Date: Wed, 26 Sep 2012 17:50:59 +0000 (+0800)
Subject: codereview: use subprocess.call() instead of os.spawnvp() for portability
X-Git-Tag: go1.1rc2~2315
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=b7331f9b3a1a5ece290c1a19cd68c58642fe26fb;p=gostls13.git

codereview: use subprocess.call() instead of os.spawnvp() for portability

Fixes #4121.

R=golang-dev, minux.ma, dave, r
CC=golang-dev
https://golang.org/cl/6555049
---

diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py
index 47317ad440..62553257bb 100644
--- a/lib/codereview/codereview.py
+++ b/lib/codereview/codereview.py
@@ -1772,7 +1772,7 @@ def gofmt(ui, repo, *pats, **opts):
 		cmd = ["gofmt", "-l"]
 		if not opts["list"]:
 			cmd += ["-w"]
-		if os.spawnvp(os.P_WAIT, "gofmt", cmd + files) != 0:
+		if subprocess.call(cmd + files) != 0:
 			raise hg_util.Abort("gofmt did not exit cleanly")
 	except hg_error.Abort, e:
 		raise