From: Bryan C. Mills <bcmills@google.com>
Date: Thu, 10 Nov 2022 14:44:39 +0000 (-0500)
Subject: go/build: in TestImportDirTarget, only expect an install target when cgo is enabled
X-Git-Tag: go1.20rc1~333
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=b820fb8df11e5ab4068b4ed9522a96bf52cf8b4d;p=gostls13.git

go/build: in TestImportDirTarget, only expect an install target when cgo is enabled

As of CL 448803, packages in GOROOT only have install targets when
they have cgo source files. When cgo is not enabled, that condition
is necessarily false, and no install target will exist.

For #47257.

Change-Id: I653a9c5f89d18a5841810f3de8d490bd7cb7e922
Reviewed-on: https://go-review.googlesource.com/c/go/+/449375
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
---

diff --git a/src/go/build/build_test.go b/src/go/build/build_test.go
index db50d45d84..3eebfd8e9e 100644
--- a/src/go/build/build_test.go
+++ b/src/go/build/build_test.go
@@ -681,8 +681,11 @@ func TestImportDirTarget(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	if p.PkgTargetRoot == "" || p.PkgObj == "" {
-		t.Errorf("p.PkgTargetRoot == %q, p.PkgObj == %q, want non-empty", p.PkgTargetRoot, p.PkgObj)
+	if p.PkgTargetRoot == "" {
+		t.Errorf("p.PkgTargetRoot == %q, want non-empty", p.PkgTargetRoot)
+	}
+	if testenv.HasCGO() && p.PkgObj == "" {
+		t.Errorf("p.PkgObj == %q, want non-empty", p.PkgObj)
 	}
 }