From: David Crawshaw Date: Tue, 6 Sep 2016 16:33:36 +0000 (-0400) Subject: cmd/link: remove outdated cast and comment X-Git-Tag: go1.8beta1~1480 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=b926bf83b0d58d7cb177dae46c011847442498c2;p=gostls13.git cmd/link: remove outdated cast and comment This program is written in Go now. Change-Id: Ieec21a1bcac7c7a59e88cd1e1359977659de1757 Reviewed-on: https://go-review.googlesource.com/28549 Reviewed-by: Brad Fitzpatrick Run-TryBot: David Crawshaw TryBot-Result: Gobot Gobot --- diff --git a/src/cmd/link/internal/ld/data.go b/src/cmd/link/internal/ld/data.go index 9c0daa1f3f..ba36210c61 100644 --- a/src/cmd/link/internal/ld/data.go +++ b/src/cmd/link/internal/ld/data.go @@ -586,13 +586,7 @@ func relocsym(ctxt *Link, s *Symbol) { o += Symaddr(ctxt, r.Sym) } - // NOTE: The (int32) cast on the next line works around a bug in Plan 9's 8c - // compiler. The expression s->value + r->off + r->siz is int32 + int32 + - // uchar, and Plan 9 8c incorrectly treats the expression as type uint32 - // instead of int32, causing incorrect values when sign extended for adding - // to o. The bug only occurs on Plan 9, because this C program is compiled by - // the standard host compiler (gcc on most other systems). - o += r.Add - (s.Value + int64(r.Off) + int64(int32(r.Siz))) + o += r.Add - (s.Value + int64(r.Off) + int64(r.Siz)) case obj.R_SIZE: o = r.Sym.Size + r.Add