From: Russ Cox <rsc@golang.org>
Date: Wed, 8 Aug 2012 01:04:57 +0000 (+1000)
Subject: misc/dashboard/codereview: fix obo
X-Git-Tag: go1.1rc2~2677
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=bacccefa8d4d8e2f4f09e9a917a1dab69f972efe;p=gostls13.git

misc/dashboard/codereview: fix obo

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6443091
---

diff --git a/misc/dashboard/codereview/dashboard/cl.go b/misc/dashboard/codereview/dashboard/cl.go
index 433232aa4f..4187ca6855 100644
--- a/misc/dashboard/codereview/dashboard/cl.go
+++ b/misc/dashboard/codereview/dashboard/cl.go
@@ -148,7 +148,8 @@ func handleAssign(w http.ResponseWriter, r *http.Request) {
 	}
 
 	u := user.Current(c)
-	if _, ok := emailToPerson[u.Email]; !ok {
+	person, ok := emailToPerson[u.Email]
+	if !ok {
 		http.Error(w, "Not allowed", http.StatusUnauthorized)
 		return
 	}
@@ -159,8 +160,7 @@ func handleAssign(w http.ResponseWriter, r *http.Request) {
 		http.Error(w, "Bad CL", 400)
 		return
 	}
-	person, ok := preferredEmail[rev]
-	if !ok && rev != "" {
+	if _, ok := preferredEmail[rev]; !ok && rev != "" {
 		c.Errorf("Unknown reviewer %q", rev)
 		http.Error(w, "Unknown reviewer", 400)
 		return