From: Adam Langley Date: Wed, 22 Jul 2015 16:31:29 +0000 (-0700) Subject: crypto/elliptic: call IsOnCurve via the interface. X-Git-Tag: go1.5beta3~119 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=bad52b352ad8ce432d394656e8d00482a25aa42e;p=gostls13.git crypto/elliptic: call IsOnCurve via the interface. https://go-review.googlesource.com/#/c/2421/ contains an unfortunate slip where IsOnCurve is called on the CurveParams rather than the curve. This doesn't really matter, but it's a pain for people doing tricks with crypto/elliptic and means that 1.5 would be a regression for them without this change. See https://groups.google.com/forum/#!topic/golang-dev/i8OPUTYctOk Change-Id: Ifa5f25f9a95d7484cb53d4883cfd78dc58a0f9a7 Reviewed-on: https://go-review.googlesource.com/12506 Reviewed-by: Russ Cox --- diff --git a/src/crypto/elliptic/elliptic.go b/src/crypto/elliptic/elliptic.go index f3b84e1eac..e6b59c5f43 100644 --- a/src/crypto/elliptic/elliptic.go +++ b/src/crypto/elliptic/elliptic.go @@ -320,7 +320,7 @@ func Unmarshal(curve Curve, data []byte) (x, y *big.Int) { } x = new(big.Int).SetBytes(data[1 : 1+byteLen]) y = new(big.Int).SetBytes(data[1+byteLen:]) - if !curve.Params().IsOnCurve(x, y) { + if !curve.IsOnCurve(x, y) { x, y = nil, nil } return