From: Cherry Zhang Date: Mon, 19 Oct 2020 18:16:31 +0000 (+0000) Subject: Revert "cmd/link: put C static symbols in the symbol table" X-Git-Tag: go1.16beta1~674 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=bb44c90a94fefcdf51caf1be05b9af6876cac2f4;p=gostls13.git Revert "cmd/link: put C static symbols in the symbol table" This reverts CL 263259. Reason for revert: break AIX builder. Change-Id: I3abb0b1f509961a06f1567d8c87679b0ca5782d7 Reviewed-on: https://go-review.googlesource.com/c/go/+/263660 Trust: Cherry Zhang Run-TryBot: Cherry Zhang Reviewed-by: Bryan C. Mills --- diff --git a/src/cmd/link/internal/ld/symtab.go b/src/cmd/link/internal/ld/symtab.go index 245a320493..dd82963a41 100644 --- a/src/cmd/link/internal/ld/symtab.go +++ b/src/cmd/link/internal/ld/symtab.go @@ -518,7 +518,7 @@ func (ctxt *Link) symtab(pcln *pclntab) []sym.SymKind { nsym := loader.Sym(ldr.NSym()) symGroupType := make([]sym.SymKind, nsym) for s := loader.Sym(1); s < nsym; s++ { - if !ctxt.IsExternal() && ldr.IsFileLocal(s) && !ldr.IsFromAssembly(s) && !ldr.IsExternal(s) { + if !ctxt.IsExternal() && ldr.IsFileLocal(s) && !ldr.IsFromAssembly(s) { ldr.SetAttrNotInSymbolTable(s, true) } if !ldr.AttrReachable(s) || ldr.AttrSpecial(s) || (ldr.SymType(s) != sym.SRODATA && ldr.SymType(s) != sym.SGOFUNC) {