From: Russ Cox <rsc@golang.org>
Date: Tue, 27 Jul 2010 00:33:50 +0000 (-0700)
Subject: codereview: avoid crash if no config
X-Git-Tag: weekly.2010-07-29~30
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=bbf925aa56bd9b7dbd07ced8506cbdf725e146a6;p=gostls13.git

codereview: avoid crash if no config

Fixes #959.

R=r
CC=golang-dev
https://golang.org/cl/1876045
---

diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py
index baed951225..84fbee61fa 100644
--- a/lib/codereview/codereview.py
+++ b/lib/codereview/codereview.py
@@ -1632,7 +1632,11 @@ def RietveldSetup(ui, repo):
 			if line.startswith('defaultcc: '):
 				defaultcc = SplitCommaSpace(line[10:])
 	except:
-		pass
+		# If there are no options, chances are good this is not
+		# a code review repository; stop now before we foul
+		# things up even worse.  Might also be that repo doesn't
+		# even have a root.  See issue 959.
+		return
 
 	try:
 		f = open(repo.root + '/CONTRIBUTORS', 'r')