From: David du Colombier <0intro@gmail.com>
Date: Wed, 18 Dec 2013 00:32:27 +0000 (-0800)
Subject: net: rewrite toLower more clearly
X-Git-Tag: go1.3beta1~1193
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=bccf029fc09c4b993f6a638b16c5fe33f0102828;p=gostls13.git

net: rewrite toLower more clearly

Rob suggested this change.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/43670044
---

diff --git a/src/pkg/net/lookup_plan9.go b/src/pkg/net/lookup_plan9.go
index 8003d177d0..a755ff2aac 100644
--- a/src/pkg/net/lookup_plan9.go
+++ b/src/pkg/net/lookup_plan9.go
@@ -73,23 +73,21 @@ func queryDNS(addr string, typ string) (res []string, err error) {
 // ASCII is sufficient to handle the IP protocol names and allow
 // us to not depend on the strings and unicode packages.
 func toLower(in string) string {
-	isAlreadyLowerCase := true
 	for _, c := range in {
 		if 'A' <= c && c <= 'Z' {
-			isAlreadyLowerCase = false
-			break
-		}
-	}
-	if isAlreadyLowerCase {
-		return in
-	}
-	out := []byte(in)
-	for i, c := range out {
-		if 'A' <= c && c <= 'Z' {
-			out[i] += 'a' - 'A'
+			// Has upper case; need to fix.
+			out := []byte(in)
+			for i := 0; i < len(in); i++ {
+				c := in[i]
+				if 'A' <= c && c <= 'Z' {
+					c += 'a' - 'A'
+				}
+				out[i] = c
+			}
+			return string(out)
 		}
 	}
-	return string(out)
+	return in
 }
 
 // lookupProtocol looks up IP protocol name and returns