From: Keith Randall <khr@golang.org>
Date: Thu, 11 Sep 2014 23:53:34 +0000 (-0700)
Subject: runtime: make gostringnocopy update maxstring
X-Git-Tag: go1.4beta1~436
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=bcd36e8857729f6f3306ab22c26e582f1d2f2932;p=gostls13.git

runtime: make gostringnocopy update maxstring

Fixes #8706

LGTM=josharian
R=josharian
CC=golang-codereviews
https://golang.org/cl/143880043
---

diff --git a/src/runtime/export_test.go b/src/runtime/export_test.go
index 1f1b5fc794..be352557fb 100644
--- a/src/runtime/export_test.go
+++ b/src/runtime/export_test.go
@@ -160,3 +160,6 @@ func GostringW(w []uint16) (s string) {
 	})
 	return
 }
+
+var Gostringnocopy = gostringnocopy
+var Maxstring = &maxstring
diff --git a/src/runtime/string.c b/src/runtime/string.c
index 811a289060..ed5debc33e 100644
--- a/src/runtime/string.c
+++ b/src/runtime/string.c
@@ -42,10 +42,15 @@ String
 runtime·gostringnocopy(byte *str)
 {
 	String s;
+	uintptr ms;
 	
 	s.str = str;
 	s.len = runtime·findnull(str);
-	return s;
+	while(true) {
+		ms = runtime·maxstring;
+		if(s.len <= ms || runtime·casp((void**)&runtime·maxstring, (void*)ms, (void*)s.len))
+			return s;
+	}
 }
 
 // TODO: move this elsewhere
diff --git a/src/runtime/string_test.go b/src/runtime/string_test.go
index e7ac51a5f0..1551ecc82b 100644
--- a/src/runtime/string_test.go
+++ b/src/runtime/string_test.go
@@ -145,3 +145,16 @@ func main() {
 	panic(s)
 }
 `
+
+func TestGostringnocopy(t *testing.T) {
+	max := *runtime.Maxstring
+	b := make([]byte, max+10)
+	for i := uintptr(0); i < max+9; i++ {
+		b[i] = 'a'
+	}
+	_ = runtime.Gostringnocopy(&b[0])
+	newmax := *runtime.Maxstring
+	if newmax != max+9 {
+		t.Errorf("want %d, got %d", max+9, newmax)
+	}
+}