From: Shenghou Ma <minux.ma@gmail.com>
Date: Sat, 20 Oct 2012 09:23:48 +0000 (+0800)
Subject: codereview: protect against read-only upstream repository
X-Git-Tag: go1.1rc2~2094
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=bcdb7926dd5f020e0cc67ca8cbec872dd666f172;p=gostls13.git

codereview: protect against read-only upstream repository

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6742053
---

diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py
index 86373ccbfb..ede91fdaed 100644
--- a/lib/codereview/codereview.py
+++ b/lib/codereview/codereview.py
@@ -1951,7 +1951,8 @@ def submit(ui, repo, *pats, **opts):
 
 		# Push changes to remote.  If it works, we're committed.  If not, roll back.
 		try:
-			hg_push(ui, repo)
+			if hg_push(ui, repo):
+				raise hg_util.Abort("push error")
 		except hg_error.Abort, e:
 			if e.message.find("push creates new heads") >= 0:
 				# Remote repository had changes we missed.