From: Brad Fitzpatrick <bradfitz@golang.org>
Date: Wed, 8 Feb 2012 03:15:25 +0000 (-0800)
Subject: net/http: don't ignore some errors in tests
X-Git-Tag: weekly.2012-02-07~3
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=c02db82b83da2f820531bebeba5604ac7aa4846a;p=gostls13.git

net/http: don't ignore some errors in tests

to help debug Issue 2651

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5644049
---

diff --git a/src/pkg/net/http/transport_test.go b/src/pkg/net/http/transport_test.go
index 321da52e27..caf81d6e46 100644
--- a/src/pkg/net/http/transport_test.go
+++ b/src/pkg/net/http/transport_test.go
@@ -441,7 +441,11 @@ func TestRoundTripGzip(t *testing.T) {
 		}
 		if accept == "gzip" {
 			rw.Header().Set("Content-Encoding", "gzip")
-			gz, _ := gzip.NewWriter(rw)
+			gz, err := gzip.NewWriter(rw)
+			if err != nil {
+				t.Errorf("gzip NewWriter: %v", err)
+				return
+			}
 			gz.Write([]byte(responseBody))
 			gz.Close()
 		} else {
@@ -460,7 +464,11 @@ func TestRoundTripGzip(t *testing.T) {
 		res, err := DefaultTransport.RoundTrip(req)
 		var body []byte
 		if test.compressed {
-			gzip, _ := gzip.NewReader(res.Body)
+			gzip, err := gzip.NewReader(res.Body)
+			if err != nil {
+				t.Errorf("%d. gzip NewReader: %v", i, err)
+				continue
+			}
 			body, err = ioutil.ReadAll(gzip)
 			res.Body.Close()
 		} else {