From: Joel Sing <joel@sing.id.au>
Date: Fri, 30 Apr 2021 18:47:00 +0000 (+1000)
Subject: runtime: work around vet asmdecl checks for openbsd/386 mstart_stub
X-Git-Tag: go1.17beta1~316
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=c23a32284a5a1e45855915a7401ebb715b837d10;p=gostls13.git

runtime: work around vet asmdecl checks for openbsd/386 mstart_stub

Include a NOP with the SP in order to disable/bypass vet asmdecl checks
for runtime.mstart_stub on openbsd/386. Without this we get:

runtime/sys_openbsd_386.s:33:1: [386] mstart_stub: use of 32(SP) points beyond argument frame

Change-Id: I834ae3dbceffcb5776481b076ec2afe3700671cf
Reviewed-on: https://go-review.googlesource.com/c/go/+/315789
Trust: Joel Sing <joel@sing.id.au>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Joel Sing <joel@sing.id.au>
---

diff --git a/src/runtime/sys_openbsd_386.s b/src/runtime/sys_openbsd_386.s
index f1911a588d..2701097c64 100644
--- a/src/runtime/sys_openbsd_386.s
+++ b/src/runtime/sys_openbsd_386.s
@@ -22,6 +22,8 @@ TEXT runtime·setldt(SB),NOSPLIT,$0
 // It just does some low-level setup and then calls mstart.
 // Note: called with the C calling convention.
 TEXT runtime·mstart_stub(SB),NOSPLIT,$28
+	NOP	SP	// tell vet SP changed - stop checking offsets
+
 	// We are already on m's g0 stack.
 
 	// Save callee-save registers.