From: Nayef Ghattas <nayef.ghattas@datadoghq.com>
Date: Wed, 12 Apr 2023 09:09:01 +0000 (+0200)
Subject: runtime/metrics: set /sched/latencies:seconds as cumulative
X-Git-Tag: go1.21rc1~793
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=c2c787d73e6fadd57ebcc9fb07532332637b9164;p=gostls13.git

runtime/metrics: set /sched/latencies:seconds as cumulative

The current implementation for this metric populates a histogram
that is never reset, i.e. where each bucket count increases
monotonically.

The comment in the definition of the Cumulative attribute calls
out that cumulative means that if the metric is a distribution,
then each bucket count increases monotonically.

In that sense, the cumulative attribute should be set to true for
this metric.

Change-Id: Ifc34e965a62f2d7881b5c8e8cbb8b7207a4d5757
Reviewed-on: https://go-review.googlesource.com/c/go/+/486755
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Felix Geisendörfer <felix.geisendoerfer@datadoghq.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Felix Geisendörfer <felix.geisendoerfer@datadoghq.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
---

diff --git a/src/runtime/metrics/description.go b/src/runtime/metrics/description.go
index 9f486d1367..0168ee912c 100644
--- a/src/runtime/metrics/description.go
+++ b/src/runtime/metrics/description.go
@@ -367,6 +367,7 @@ var allDesc = []Description{
 		Name:        "/sched/latencies:seconds",
 		Description: "Distribution of the time goroutines have spent in the scheduler in a runnable state before actually running.",
 		Kind:        KindFloat64Histogram,
+		Cumulative:  true,
 	},
 	{
 		Name:        "/sync/mutex/wait/total:seconds",