From: Brad Fitzpatrick Date: Thu, 23 Mar 2017 03:56:23 +0000 (+0000) Subject: net: mark TestDialerDualStack as flaky X-Git-Tag: go1.9beta1~1022 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=c46226a6222eb8bc8b30b40e8ce09ebe00f5dade;p=gostls13.git net: mark TestDialerDualStack as flaky It was already marked flaky for everything but the dashboard. Remove that restriction. It's just flaky overall. It's doing more harm than good. Updates #13324 Change-Id: I36feff32a1b8681e77700f74b9c70cb4073268eb Reviewed-on: https://go-review.googlesource.com/38459 Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot Reviewed-by: Josh Bleecher Snyder --- diff --git a/src/net/dial_test.go b/src/net/dial_test.go index 9825bc92ab..e8547974b9 100644 --- a/src/net/dial_test.go +++ b/src/net/dial_test.go @@ -715,11 +715,8 @@ func TestDialerLocalAddr(t *testing.T) { } func TestDialerDualStack(t *testing.T) { - // This test is known to be flaky. Don't frighten regular - // users about it; only fail on the build dashboard. - if testenv.Builder() == "" { - testenv.SkipFlaky(t, 13324) - } + testenv.SkipFlaky(t, 13324) + if !supportsIPv4 || !supportsIPv6 { t.Skip("both IPv4 and IPv6 are required") }