From: Rob Pike <r@golang.org>
Date: Sun, 8 May 2011 15:32:18 +0000 (-0700)
Subject: reflect: make allocation test less fragile.
X-Git-Tag: release.r57.2~5
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=c57f672d63d0e13a980def455837043145176451;p=gostls13.git

reflect: make allocation test less fragile.
When GOMAXPROCS>1, the testing framework runs in parallel with the
test itself and may do a small number of allocations, so allow the
"noAllocs" condition to admit just a few.

Fixes #1782.

R=rsc
CC=golang-dev
https://golang.org/cl/4533041
---

diff --git a/src/pkg/reflect/all_test.go b/src/pkg/reflect/all_test.go
index dee3f4915b..e20e03f501 100644
--- a/src/pkg/reflect/all_test.go
+++ b/src/pkg/reflect/all_test.go
@@ -1459,7 +1459,9 @@ func noAlloc(t *testing.T, n int, f func(int)) {
 	for j := 0; j < n; j++ {
 		f(j)
 	}
-	if runtime.MemStats.Mallocs != 0 {
+	// A few allocs may happen in the testing package when GOMAXPROCS > 1, so don't
+	// require zero mallocs.
+	if runtime.MemStats.Mallocs > 5 {
 		t.Fatalf("%d mallocs after %d iterations", runtime.MemStats.Mallocs, n)
 	}
 }