From: Than McIntosh Date: Thu, 31 Mar 2022 17:15:51 +0000 (-0400) Subject: debug/pe: skip TestReadCOFFSymbolAuxInfo on big-endian systems X-Git-Tag: go1.19beta1~841 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=c5c66d78b21074c562ece01d6682d4a499815786;p=gostls13.git debug/pe: skip TestReadCOFFSymbolAuxInfo on big-endian systems Disable the new TestReadCOFFSymbolAuxInfo testpoint on big endian systems, pending resolution of issue 52079. The newly added interfaces for reading symbol definition aux info is not working properly when reading PE objects obj big-endian systems. Updates #52079. Change-Id: I8d55c7e4c03fc6444ef06a6a8154cb50596ca58a Reviewed-on: https://go-review.googlesource.com/c/go/+/397294 Trust: Than McIntosh Run-TryBot: Than McIntosh TryBot-Result: Gopher Robot Reviewed-by: Cherry Mui --- diff --git a/src/debug/pe/symbols_test.go b/src/debug/pe/symbols_test.go index c4dcd95391..5ccf635830 100644 --- a/src/debug/pe/symbols_test.go +++ b/src/debug/pe/symbols_test.go @@ -6,6 +6,7 @@ package pe import ( "fmt" + "runtime" "testing" ) @@ -17,6 +18,13 @@ type testpoint struct { } func TestReadCOFFSymbolAuxInfo(t *testing.T) { + + switch runtime.GOARCH { + case "mips", "mips64", "ppc64", "s390x": + t.Skipf("Skipping on %s (big endian) until issue #52079 fixed", + runtime.GOARCH) + } + testpoints := map[int]testpoint{ 39: testpoint{ name: ".rdata$.refptr.__native_startup_lock",