From: Brad Fitzpatrick Date: Tue, 21 May 2013 02:26:26 +0000 (-0700) Subject: net/http: use WriteString directly when possible X-Git-Tag: go1.2rc2~1461 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=c6c439d7a0be6bfb91348d8a76b09ffd173688fa;p=gostls13.git net/http: use WriteString directly when possible Several places used io.WriteString unnecessarily when the static type already implemented WriteString. No need to check for it at runtime. R=golang-dev, r CC=golang-dev https://golang.org/cl/9608043 --- diff --git a/src/pkg/net/http/server.go b/src/pkg/net/http/server.go index 698d3f9d46..e000285047 100644 --- a/src/pkg/net/http/server.go +++ b/src/pkg/net/http/server.go @@ -278,7 +278,7 @@ func (cw *chunkWriter) close() { // zero EOF chunk, trailer key/value pairs (currently // unsupported in Go's server), followed by a blank // line. - io.WriteString(cw.res.conn.buf, "0\r\n\r\n") + cw.res.conn.buf.WriteString("0\r\n\r\n") } } @@ -512,7 +512,7 @@ func (ecr *expectContinueReader) Read(p []byte) (n int, err error) { } if !ecr.resp.wroteContinue && !ecr.resp.conn.hijacked() { ecr.resp.wroteContinue = true - io.WriteString(ecr.resp.conn.buf, "HTTP/1.1 100 Continue\r\n\r\n") + ecr.resp.conn.buf.WriteString("HTTP/1.1 100 Continue\r\n\r\n") ecr.resp.conn.buf.Flush() } return ecr.readCloser.Read(p) @@ -847,7 +847,7 @@ func (cw *chunkWriter) writeHeader(p []byte) { setHeader.connection = "close" } - io.WriteString(w.conn.buf, statusLine(w.req, code)) + w.conn.buf.WriteString(statusLine(w.req, code)) cw.header.WriteSubset(w.conn.buf, excludeHeader) setHeader.Write(w.conn.buf.Writer) w.conn.buf.Write(crlf)