From: Austin Clements <austin@google.com>
Date: Tue, 13 Nov 2018 23:38:49 +0000 (-0500)
Subject: cmd/go: more cross-package references from internal/syscall/unix
X-Git-Tag: go1.12beta1~283
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=c6d493937e7047057a9833661d6d20ce72f904b4;p=gostls13.git

cmd/go: more cross-package references from internal/syscall/unix

On some platforms, assembly in internal/syscall/unix references
unexported runtime symbols. Catch these references so the compiler can
generate the necessary ABI wrappers.

Fixes #28769.
Updates #27539.

Change-Id: I118eebfb8b3d907b4c3562198e6afb49854f5827
Reviewed-on: https://go-review.googlesource.com/c/149817
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Clément Chigot <clement.chigot@atos.net>
Reviewed-by: Keith Randall <khr@golang.org>
---

diff --git a/src/cmd/go/internal/work/gc.go b/src/cmd/go/internal/work/gc.go
index a14a970ffb..c0c457cbad 100644
--- a/src/cmd/go/internal/work/gc.go
+++ b/src/cmd/go/internal/work/gc.go
@@ -295,9 +295,9 @@ func (gcToolchain) symabis(b *Builder, a *Action, sfiles []string) (string, erro
 	// Gather known cross-package references from assembly code.
 	var otherPkgs []string
 	if p.ImportPath == "runtime" {
-		// Assembly in syscall and runtime/cgo references
+		// Assembly in the following packages references
 		// symbols in runtime.
-		otherPkgs = []string{"syscall", "runtime/cgo"}
+		otherPkgs = []string{"syscall", "internal/syscall/unix", "runtime/cgo"}
 	} else if p.ImportPath == "runtime/internal/atomic" {
 		// sync/atomic is an assembly wrapper around
 		// runtime/internal/atomic.